Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc: gcc_13 → gcc_14 #340612

Merged
merged 8 commits into from
Sep 12, 2024
Merged

gcc: gcc_13 → gcc_14 #340612

merged 8 commits into from
Sep 12, 2024

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Sep 8, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabianhjr
Copy link
Member Author

Cherry-picked a fix by @trofi from #340013

@fabianhjr fabianhjr requested review from vcunat and alyssais September 8, 2024 23:30
@fabianhjr
Copy link
Member Author

Currently doing a nixos-rebuild on x86_64-linux, stdenv + ~2k packages built so far (still missing another 1k builds for my config)

@vcunat
Copy link
Member

vcunat commented Sep 9, 2024

https://gcc.gnu.org/gcc-14/porting_to.html

@github-actions github-actions bot added the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Sep 9, 2024
@fabianhjr
Copy link
Member Author

fabianhjr commented Sep 9, 2024

Was able to boot into this via nixos-rebuild (plus two non included commits that disable tests for afdko and perlPackages.Po4a)

Everything seems fine.

@fabianhjr fabianhjr marked this pull request as ready for review September 9, 2024 05:43
@fabianhjr
Copy link
Member Author

fabianhjr commented Sep 9, 2024

Tagging maintainers on the changes I'm not 100% sure on.

afdko: @sternenseemann, dropped some tests

Steam fhsenv drop of gconf is on a separated merge request and I intend to rebase this when that is merged and reaches current staging-next: #340633

@alyssais
Copy link
Member

alyssais commented Sep 9, 2024

Commit messages could use some more explanation — it's going to be very difficult to somebody looking at the history of a package in a couple of years to figure out why dependencies were dropped if it's not explained at all.

@stigtsp
Copy link
Member

stigtsp commented Sep 9, 2024

We need to keep this in mind re the perl 5.40.0 update in #333286 as well

fabianhjr added a commit to fabianhjr/nixpkgs that referenced this pull request Sep 9, 2024
GConf depends on ORBit2 which no longer compiles on NixOS#340612

ORBit2 / GConf are EOL/Archived:

- https://gitlab.gnome.org/Archive/orbit2 (last commit on main branch 8 years ago)
- https://gitlab.gnome.org/Archive/gconf (last commit on main branch 8 years ago)
@fabianhjr fabianhjr marked this pull request as draft September 9, 2024 14:54
@github-actions github-actions bot removed the 6.topic: steam Steam game store/launcher (store.steampowered.com) label Sep 9, 2024
@fabianhjr fabianhjr marked this pull request as ready for review September 9, 2024 21:22
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Sep 10, 2024
@fabianhjr fabianhjr marked this pull request as ready for review September 10, 2024 21:45
@fabianhjr
Copy link
Member Author

Hi @vcunat, I believe most changes have been painless enough, I could help with further breakage during the next staging-next cycle.

@fabianhjr
Copy link
Member Author

@alyssais, removed the dependency drops from this PR, seems to build fine now (I think I carried over those drops by mistake while experimenting with this branch)

@philiptaron
Copy link
Contributor

Barring any objections, I'd like to land this in the next couple days.

fabianhjr and others added 8 commits September 11, 2024 01:44
When `vulkan-headers` detects `gcc-14` or above it enables c++ modules
support. But make-mased backend does not support it and fails as:

    $ nix build --impure --expr 'with import ./. {}; vulkan-headers.override {stdenv = gcc14Stdenv; }' -L

    CMake Error in CMakeLists.txt:
      The target named "Vulkan-Module" has C++ sources that may use modules, but
      modules are not supported by this generator:
        Unix Makefiles
      Modules are supported only by Ninja, Ninja Multi-Config, and Visual Studio
      generators for VS 17.4 and newer.  See the cmake-cxxmodules(7) manual for
      details.  Use the CMAKE_CXX_SCAN_FOR_MODULES variable to enable or disable
      scanning.
@philiptaron philiptaron merged commit 572baa7 into NixOS:staging Sep 12, 2024
26 checks passed
@fabianhjr fabianhjr deleted the gcc-14-stdenv branch September 12, 2024 22:51
@alyssais
Copy link
Member

libaom no longer builds on aarch64-linux due to an internal compiler error, which I have reported upstream. That breaks 26810 packages. Continuing to discuss and investigate in #staging:nixos.org.

@alyssais
Copy link
Member

We got lucky: #342306

@philiptaron
Copy link
Contributor

philiptaron commented Sep 24, 2024

We've decided to revert this due to multiple internal compiler errors on aarch64.

@corngood
Copy link
Contributor

a55b0ea seems to have broken jam. See #349044.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants