Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: drop GConf dependency #342368

Merged
merged 1 commit into from
Sep 17, 2024
Merged

emacs: drop GConf dependency #342368

merged 1 commit into from
Sep 17, 2024

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Sep 16, 2024 •
edited
Loading

Description of changes

Part of #39976 and #340612

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Sep 16, 2024
@fabianhjr fabianhjr added the 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages label Sep 16, 2024
@AndersonTorres
Copy link
Member

Hum, please can I grab this into #341656?
I am planning to update Emacs expression.

@fabianhjr
Copy link
Member Author

Sure, let me know if I should close this PR

@fabianhjr
Copy link
Member Author

Though, this should be a 0 rebuild PR as it is so probably best to merge this and rebase the other PR if you are going to rebase/amend anyways.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 16, 2024
@fabianhjr
Copy link
Member Author

Result of nixpkgs-review pr 342368 run on x86_64-linux 1

@AndersonTorres
Copy link
Member

Well, with some luck it will rebase cleanly. Let's wait ofBorg and merge this.

@jian-lin jian-lin merged commit 7233981 into NixOS:master Sep 17, 2024
29 of 31 checks passed
@fabianhjr fabianhjr deleted the emacs-drop-gconf branch September 17, 2024 02:07
@AndersonTorres
Copy link
Member

P.S.: should we drop GTK2 support too? Or is it too soon?

@fabianhjr
Copy link
Member Author

probably should be dropped too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jian-lin jian-lin jian-lin approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@K900 K900 Awaiting requested review from K900

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: emacs Text editor 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianhjr @AndersonTorres @jian-lin