Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "gcc: gcc_13 → gcc_14" #344210

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Revert "gcc: gcc_13 → gcc_14" #344210

merged 1 commit into from
Sep 24, 2024

Conversation

alyssais
Copy link
Member

Description of changes

This reverts commit e9cdb22.

We've encountered multiple GCC 14 internal compiler errors on aarch64. If we wanted to keep it as the default compiler, we'd either have to track the 14.x release branch, or backport about half of it. One Bugzilla thread mentions six patches that should be backported. This doesn't feel good to have as the default compiler. Let's stick with 13 for now until 14.3 is released, hopefully with all the fixes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit e9cdb22.

We've encountered multiple GCC 14 internal compiler errors on aarch64.
If we wanted to keep it as the default compiler, we'd either have to
track the 14.x release branch, or backport about half of it.  One
Bugzilla thread mentions six patches that should be backported.  This
doesn't feel good to have as the default compiler.  Let's stick with
13 for now until 14.3 is released, hopefully with all the fixes.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Sep 24, 2024
@K900 K900 merged commit 41e40d8 into NixOS:staging-next Sep 24, 2024
8 of 9 checks passed
@alyssais alyssais deleted the revert-gcc branch September 24, 2024 13:09
@philiptaron
Copy link
Contributor

philiptaron commented Sep 24, 2024

Thanks @alyssais. This is the right call given the evidence.

Original PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants