qpakman: init at unstable-2024-03-07 #301876
Conversation
ofborg
bot
added
8.has: package (new)
not-leader
changed the title
There was a problem hiding this comment.
Nice, just a few relatively minor comments. I just threw a quake1 shareware pak at it to test, basic functionality seems to be working fine:
$ nix run .#qpakman -- -l ~/Downloads/pak0.pak
**** QPAKMAN v0.67 (C) 2008 Andrew Apted ****
Opened PAK file: /home/john/Downloads/pak0.pak
--------------------------------------------------
1: +0000000c 00001aa6 : sound/items/r_item1.wav
2: +00001ab2 00001d18 : sound/items/r_item2.wav
3: +000037ca 00001f16 : sound/items/health1.wav
4: +000056e0 00002724 : sound/misc/medkey.wav
5: +00007e04 000038f2 : sound/misc/runekey.wav
6: +0000b6f6 00005808 : sound/items/protect.wav
7: +00010efe 000084dc : sound/items/protect2.wav
8: +000193da 00005b44 : sound/items/protect3.wav
9: +0001ef1e 00003dee : sound/items/suit.wav
...| description = "A command-line tool for managing PAK and WAD files from QuakeI/II & Hexen II"; | ||
| longDescription = ''''; | ||
| license = licenses.gpl2Plus; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
Do you want to add yourself as a maintainer? To do so, you'll want to add yourself to maintainer-list.nix. See the documentation. I believe it is fine to do this in the same PR as other changes as long as it's in a separate commit before the commit adding the actual package.
| license = licenses.gpl2Plus; | ||
| maintainers = [ ]; | ||
| platforms = platforms.unix; | ||
| }; |
There was a problem hiding this comment.
Could you also set the mainProgram attribute of meta to qpakman? This will make things like nix run nixpkgs#qpakman work. Right now it will work since the pname and the mainProgram are the same, but this behavior is being deprecated, so derivations that have a "primary" program should set mainProgram from now on.
Co-authored-by: jchv <[email protected]>
Co-authored-by: jchv <[email protected]>
ofborg
bot
added
the
11.by: package-maintainer
This reverts commit f3c76cd.
|
yipeeee |
|
@jchv any update on this? |
Co-authored-by: Yohann Boniface <[email protected]>
Co-authored-by: Yohann Boniface <[email protected]>
Co-authored-by: Yohann Boniface <[email protected]>
|
sorry to ping again |
|
There was a problem hiding this comment.
This still LGTM overall, but the commits need to be squashed, and the squashed commit message should follow the CONTRIBUTING.md specification. There can be multiple commits in a single PR, but there shouldn't be redundant commits (e.g. adding something then changing it immediately after, or adding something and reverting it.) I hate to be picky, but it's just part of the conventions.
| homepage = "https://github.com/fhomolka/qpakman"; | ||
| description = "command-line tool for managing PAK and WAD files from QuakeI/II & Hexen II"; | ||
| license = licenses.gpl2Plus; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
New packages must have a maintainer.
the original poster @not-leader |
Sure. Someone else can create a new PR based on this one. |
FliegendeWurst
added
9.needs: maintainer
oof :c I need this tool for the dev work I do just sad to see it get delayed |
|
Sorry to hear that this has been impacting you. It would be relatively easy for someone to adopt this, but I personally don't think I should as I am not a developer of Quake/Quake II mods and don't know a whole lot about qpakman. If you would like to have this derivation as a part of your NixOS or nix-darwin configuration, it would not be too difficult to lift the derivation out of here and put it into your configuration for the time being. Just copy out the { pkgs, ... }:
{
environment.systemPackages = [
(pkgs.callPackage ./package.nix { })
];
}It's also relatively easy to construct a Nix flake for qpakman that can be used with Hopefully someone with subject matter experience will step up to be a maintainer so that it can be merged into Nixpkgs. |
Description of changes
Forum post describing older version of package: https://openarena.ws/board/index.php?topic=1710.0
Adds me (not_leader) as maintainer for package
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.