Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpakman: init at unstable-2024-03-07 #301876

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

qpakman: init at unstable-2024-03-07 #301876

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
00a2404
qpakman: init at 2024-03-07
Apr 5, 2024
bbe2b62
qpakman: add "unstable-" to package version
not-leader Apr 5, 2024
7d967cb
qpakman: remove package definition in all-packages.nix
not-leader Apr 5, 2024
c7ba1ea
qpakman: remove empty meta.longDescription
not-leader Apr 6, 2024
2076cfb
qpakman: replace sha256 with hash
not-leader Apr 6, 2024
f3c76cd
maintainers: add not_leader
Apr 6, 2024
749119d
qpakman: set meta.mainProgram to "qpakman"
Apr 6, 2024
e042e78
Revert "maintainers: add not_leader"
not-leader Apr 21, 2024
5d86a25
qpakman: prepend 0- to version name
not-leader Aug 14, 2024
a7a1932
qpakman: remove article from package description
not-leader Aug 14, 2024
1a4ea44
qpakman: fix formatting
not-leader Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions pkgs/by-name/qp/qpakman/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
lib,
stdenv,
fetchFromGitHub,
pkg-config,
cmake,
libpng,
zlib,
}:
stdenv.mkDerivation {
pname = "qpakman";
version = "unstable-2024-03-07";

src = fetchFromGitHub {
owner = "fhomolka";
repo = "qpakman";
rev = "5a76df23c11f4da619448c60a1a2ba35c316ec2b";
hash = "sha256-DzP1PTzXRn8mKnPzMpxXnN9ZvFPMWWuVedll+FjFcj4=";
};

nativeBuildInputs = [
cmake
pkg-config
];
buildInputs = [
libpng
zlib
];

meta = with lib; {
homepage = "https://github.com/fhomolka/qpakman";
description = "A command-line tool for managing PAK and WAD files from QuakeI/II & Hexen II";
license = licenses.gpl2Plus;
maintainers = [ ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add yourself as a maintainer? To do so, you'll want to add yourself to maintainer-list.nix. See the documentation. I believe it is fine to do this in the same PR as other changes as long as it's in a separate commit before the commit adding the actual package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New packages must have a maintainer.

platforms = platforms.unix;
mainProgram = "qpakman";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also set the mainProgram attribute of meta to qpakman? This will make things like nix run nixpkgs#qpakman work. Right now it will work since the pname and the mainProgram are the same, but this behavior is being deprecated, so derivations that have a "primary" program should set mainProgram from now on.

}