Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qpakman: init at unstable-2024-03-07 #301876

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
39 changes: 39 additions & 0 deletions pkgs/by-name/qp/qpakman/package.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
lib,
stdenv,
fetchFromGitHub,
pkg-config,
cmake,
libpng,
zlib,
}:
stdenv.mkDerivation {
pname = "qpakman";
version = "0-unstable-2024-03-07";

src = fetchFromGitHub {
owner = "fhomolka";
repo = "qpakman";
rev = "5a76df23c11f4da619448c60a1a2ba35c316ec2b";
hash = "sha256-DzP1PTzXRn8mKnPzMpxXnN9ZvFPMWWuVedll+FjFcj4=";
};

nativeBuildInputs = [
cmake
pkg-config
];

buildInputs = [
libpng
zlib
];

meta = with lib; {
homepage = "https://github.com/fhomolka/qpakman";
description = "command-line tool for managing PAK and WAD files from QuakeI/II & Hexen II";
license = licenses.gpl2Plus;
maintainers = [ ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add yourself as a maintainer? To do so, you'll want to add yourself to maintainer-list.nix. See the documentation. I believe it is fine to do this in the same PR as other changes as long as it's in a separate commit before the commit adding the actual package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New packages must have a maintainer.

platforms = platforms.unix;
mainProgram = "qpakman";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also set the mainProgram attribute of meta to qpakman? This will make things like nix run nixpkgs#qpakman work. Right now it will work since the pname and the mainProgram are the same, but this behavior is being deprecated, so derivations that have a "primary" program should set mainProgram from now on.

}