Including common Non SFA functions #536

situx · 2024-07-12T15:22:37Z

Closes #257
Closes #341
Closes #400

aggCollect function
DWithin function
metricDWithin function
isCollection function
simplifyDP function

Merge DWithin Pull Request content with Non SFA Functions

nicholascar

Why are acronyms used here like DWithin when previous functions all use full wording such as hasMetricParameterLength? Prefer consistencey across all functions unless a justification is provided
Reference for the Douglas-Peucker algorithm needed

situx · 2024-08-05T20:12:39Z

Valid points.
Should we name it geof:DistanceWithin then?

@reference:
David Douglas, Thomas Peucker: Algorithms for the reduction of the number of points required to represent a digitized line or its caricature. In: The Canadian Cartographer. Band 10, Nr. 2, 1973, ISSN 0008-3127, S. 112–122.

mperry455

Approved pending suggested changes by @nicholascar

mperry455 · 2024-08-07T13:28:06Z

spec/sections/11-geometry_extension.adoc

+geof:aggCollect (geom: ogc:geomLiteral): ogc:geomLiteral
+```
+
+The function http://www.opengis.net/def/function/geosparql/aggCollect[`geof:aggCollect`] calculates creates a GeometryCollection literal out of a set of geometries.


Typo: "calculates creates"

does geom: ogc:geomLiteral indicate that it's an array/set?

It is a set of ogc:geomLiterals in practice likely bound to a SPARQL variable like in other functions too.
The content of the ogc:geomLiterals could be arrays, e.g. a WKT GeometryCollection could be considered as an array.
Does that answer your question or would you have a different idea how to mark an array/set?

@situx I saw your answer in another issue that one geomLiteral can carry a collection.
But I think this is different: aggregates work on a resultset of multiple geomLiterals, so the function signature should indicate an array. Eg use geomLiteral*

My comment is answered. But @mperry455 's comment not answered yet

mperry455 · 2024-08-07T13:32:53Z

I feel like geof:withinDistance reads a little better than geof:distanceWithin.

VladimirAlexiev · 2024-08-07T20:32:01Z

Rename simplifyDP to simplify. When another (less popular algorithm) needs to be added, it can get a longer name simplifyFoo.

Simplify! :-)

jabhay · 2024-08-07T20:32:46Z

Discussed simplifyDP function. Given it's the only simplification function being considered currently, we arrived at the decision to call it just simplify.

VladimirAlexiev

geomLiteral array

jabhay · 2024-09-04T20:16:29Z

Would be good to get a few eyes on the options below. Please indicate your preferred options by using thumbs up. You can thumbs down if you're very much against an option.

Can people add their thoughts to this before next meeting? Please indicate which option you like. All options require that we add an explanation in the explanatory notes section up top.

jabhay · 2024-09-04T20:19:42Z

Recommended above: geomLiteral*

jabhay · 2024-09-04T20:19:56Z

Other option in line with other programming languages: geomLiteral[] and add explanatory text to describe it.

jabhay · 2024-09-04T20:20:01Z

Leave as is, and explain it

jabhay · 2024-09-18T20:55:28Z

Voting result: annotate as ogc:geomLiteral[] and add explanatory text to describe it.

situx · 2024-09-19T18:54:56Z

I added the array notation to all spatial aggregate functions, added a paragraph to explain the syntax and corrected some mistakes. The PR is therefore again ready for review.

mperry455 · 2024-10-02T19:20:28Z

spec/sections/11-geometry_extension.adoc

@@ -1203,6 +1203,8 @@ Implementations shall support the functions
 <<Function: geof:boundingCircle, `geof:boundingCircle`>>, 
 <<Function: geof:metricBuffer, `geof:metricBuffer`>>, 
 <<Function: geof:buffer, `geof:buffer`>>, 
+<<Function: geof:metricWithinDistance, `geof:metricWithinDistance`>>, 
+<<Function: geof:WithinDistance, `geof:WithinDistance`>>, 


Lowercase 'w'? geof:withinDistance instead of geof:WithinDistance

mperry455 · 2024-10-02T19:21:30Z

spec/sections/11-geometry_extension.adoc

+
+Returns true if `geom2` is within a given distance of `geom1`. Calculations are according to the units in the spatial reference system of `geom1`. The triple store implementation needs to take care of a conversion between meter and the unit of the spatial reference system.
+
+==== Function: geof:sfWithinDistance


geof:withinDistance?

VladimirAlexiev · 2024-10-03T11:48:06Z

spec/sections/07-conventions.adoc

@@ -57,6 +57,12 @@ The following IRI namespace prefixes are used throughout this document:

 All of these namespace prefixes in the previous section resolve to resources that contain their namespace content except for `eg:` (`http://example.com/`), which is used just for examples, and `ogc:` (`http://www.opengis.net/`), which is used in requirement specifications as a placeholder for the geometry literal serialization used in a fully-qualified conformance class, e.g. http://www.opengis.net/ont/geosparql#wktLiteral[`+<http://www.opengis.net/ont/geosparql#wktLiteral>+`].

+=== Data Types for Spatial Aggregate Functions
+
+In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification.


which -> that

VladimirAlexiev · 2024-10-03T11:48:35Z

spec/sections/07-conventions.adoc

+=== Data Types for Spatial Aggregate Functions
+
+In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification.
+To express a list of such literals, for example as input parameters for spatial aggregate functions, we use the notation ogc:geomLiteral[].


don't you need to put ogc:geomLiteral[] in some code markers? (I'm not familiar with adoc)

I do not think so. However, should we find it disturbing we can still correct the styling later on

VladimirAlexiev · 2024-10-03T11:49:39Z

spec/sections/07-conventions.adoc

+
+In this specification we use the placeholder URI ogc:geomLiteral to describe any geometry literal which is defined in this specification.
+To express a list of such literals, for example as input parameters for spatial aggregate functions, we use the notation ogc:geomLiteral[].
+We do not define the order of ogc:geomLiteral[]. The order is to be determined by implementers.


I don't understand that. A "list" is ordered, so how do you mean implementers can change it?

A list is ordered. But how it is ordered, e.g., by URI alphabetically or not at all, should be up to the implementers.

VladimirAlexiev · 2024-10-03T11:50:49Z

spec/sections/11-geometry_extension.adoc

+                 distance: xsd:double): xsd:boolean
+```
+
+Returns true if `geom2` is within a given distance of `geom1`. Calculations are according to the units in the spatial reference system of `geom1`. The triple store implementation needs to take care of a conversion between meter and the unit of the spatial reference system.


"given distance of geom1" -> add "in meters"

VladimirAlexiev · 2024-10-03T11:52:41Z

spec/sections/11-geometry_extension.adoc

+geof:aggCollect (geom: ogc:geomLiteral): ogc:geomLiteral
+```
+
+The function http://www.opengis.net/def/function/geosparql/aggCollect[`geof:aggCollect`] calculates creates a GeometryCollection literal out of a set of geometries.


My comment is answered. But @mperry455 's comment not answered yet

mperry455 · 2024-10-16T19:17:36Z

Per SWG discussion on 10/16/2024:
Regarding ordering of ogc:geometryLiteral[] input to aggregates to make result CRS deterministic, it may be hard to enforce an ordering on implementers. Here are some possible options:

Leave it up to implementers to determine the output CRS
Add a new target_crs argument to aggregate functions
Document that users can transform the output of the aggregate to their desired CRS
Specify an ordering criteria

Please comment on this thread with opinions on the options.

nicholascar · 2024-10-30T19:15:05Z

Per SWG discussion on 10/16/2024: Regarding ordering of ogc:geometryLiteral[] input to aggregates to make result CRS deterministic, it may be hard to enforce an ordering on implementers. Here are some possible options:
1. Leave it up to implementers to determine the output CRS

2. Add a new target_crs argument to aggregate functions

3. Document that users can transform the output of the aggregate to their desired CRS

4. Specify an ordering criteria
Please comment on this thread with opinions on the options.

I vote for:

Document that users can transform the output of the aggregate to their desired CRS

(if the implementers support this functionality - probably will)

ultimately

Leave it up to implementers to determine the output CRS

jabhay · 2024-11-13T20:23:54Z

Vote regarding ordering of ogc:geometryLiteral[] input to aggregates to make result CRS deterministic. Thumbs up is in favour, Thumbs down is have objections.

jabhay · 2024-11-13T20:24:22Z

Option 1: Leave it up to implementers to determine the output CRS

jabhay · 2024-11-13T20:24:57Z

Option 2: Add a new target_crs argument to aggregate functions

jabhay · 2024-11-13T20:25:25Z

Option 3: Document that users can transform the output of the aggregate to their desired CRS and then leave it up to implementers to determine the output CRS

jabhay · 2024-11-13T20:25:48Z

Option 4: Specify an ordering criteria

situx · 2025-02-16T21:34:50Z

I added a comment on parameters of spatial aggregate functions, so this pull request is now again ready for review

situx added 11 commits June 1, 2022 19:53

Update 11-Part-08.adoc

09f1f93

Update 11-Part-08.adoc

bbf34f7

Non SFA functions for GeoSPARQL 1.2

9e74ce6

Added simplifyDP function

425469b

Added isCollection function

bdd054d

Merge pull request #415 from opengeospatial/situx-patch-dwithin

fe41ae9

Merge DWithin Pull Request content with Non SFA Functions

Add DWithin to funcsrules

eef73d7

Merge branch 'master' into situx-patch-6

d15b067

Merge branch 'master' into situx-patch-6

2ae2822

Merge branch 'master' into situx-patch-6

cd76660

Merge branch 'geosparql-1.3' into situx-patch-6

f580f57

situx changed the base branch from master to geosparql-1.3 July 12, 2024 15:23

situx added 3 commits July 12, 2024 17:26

Update 11-geometry_extension.adoc

699615f

Update functions.ttl

e274933

Update functions.ttl

fc0555b

situx marked this pull request as ready for review July 12, 2024 15:34

mperry455 requested review from nicholascar and mperry455 July 24, 2024 21:00

nicholascar requested changes Aug 4, 2024

View reviewed changes

mperry455 approved these changes Aug 7, 2024

View reviewed changes

jabhay marked this pull request as draft August 7, 2024 20:30

situx added 5 commits August 8, 2024 17:37

Update functions.ttl

b4f6b14

Update 11-geometry_extension.adoc

456a429

Update az-bibliography.adoc

402ab7f

Update 11-geometry_extension.adoc

fd7ec1d

Update 11-geometry_extension.adoc

54562ce

situx marked this pull request as ready for review August 8, 2024 18:23

Merge branch 'geosparql-1.3' into nonsffunctions

2672416

VladimirAlexiev requested changes Sep 4, 2024

View reviewed changes

situx added 3 commits September 19, 2024 20:38

Update 11-geometry_extension.adoc

b40f337

Update 01-preface.adoc

c5cbafb

Update 07-conventions.adoc

8509daa

situx requested a review from VladimirAlexiev September 19, 2024 18:55

mperry455 approved these changes Oct 2, 2024

View reviewed changes

Update 11-geometry_extension.adoc

ef6106a

VladimirAlexiev requested changes Oct 3, 2024

View reviewed changes

ar-chad mentioned this pull request Oct 17, 2024

Use Case ONTO19: Within Distance #569

Closed

ar-chad mentioned this pull request Nov 14, 2024

Use Case Municipality Rotterdam 2 #582

Open

situx added 4 commits January 15, 2025 15:12

Update 07-conventions.adoc

51b95c3

Update 11-geometry_extension.adoc

2bc05f3

Update 11-geometry_extension.adoc

6cfe262

Update 11-geometry_extension.adoc

6e13ea7


		Returns true if `geom2` is within a given distance of `geom1`. Calculations are according to the units in the spatial reference system of `geom1`. The triple store implementation needs to take care of a conversion between meter and the unit of the spatial reference system.

		==== Function: geof:sfWithinDistance

Including common Non SFA functions #536

Are you sure you want to change the base?

Including common Non SFA functions #536

Conversation

situx commented Jul 12, 2024

nicholascar left a comment • edited by situx Loading

Choose a reason for hiding this comment

situx commented Aug 5, 2024 • edited Loading

mperry455 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VladimirAlexiev Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

situx Aug 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mperry455 commented Aug 7, 2024

VladimirAlexiev commented Aug 7, 2024

jabhay commented Aug 7, 2024

VladimirAlexiev left a comment

Choose a reason for hiding this comment

jabhay commented Sep 4, 2024 • edited Loading

jabhay commented Sep 4, 2024

jabhay commented Sep 4, 2024 • edited Loading

jabhay commented Sep 4, 2024

jabhay commented Sep 18, 2024

situx commented Sep 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mperry455 commented Oct 16, 2024 • edited Loading

nicholascar commented Oct 30, 2024

jabhay commented Nov 13, 2024

jabhay commented Nov 13, 2024

jabhay commented Nov 13, 2024

jabhay commented Nov 13, 2024 • edited Loading

jabhay commented Nov 13, 2024

situx commented Feb 16, 2025

nicholascar left a comment •

edited by situx

Loading

situx commented Aug 5, 2024 •

edited

Loading

VladimirAlexiev Aug 7, 2024 •

edited

Loading

situx Aug 20, 2024 •

edited

Loading

jabhay commented Sep 4, 2024 •

edited

Loading

jabhay commented Sep 4, 2024 •

edited

Loading

mperry455 commented Oct 16, 2024 •

edited

Loading

jabhay commented Nov 13, 2024 •

edited

Loading