Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpreter: set shared_library_only for default_library='shared' #14237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iyzsong
Copy link

@iyzsong iyzsong commented Feb 11, 2025

Hello, this fixes #3970, so that pc files generated by library when default_library=shared doesn't include Requires.private.

Thanks.

@iyzsong
Copy link
Author

iyzsong commented Feb 11, 2025

Document "Implicit dependencies" in Pkgconfig-module.md need to be updated.

I think the unit test 76 as link whole really is for static_library, for a shared library it's dependencies are alreally linked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't add private dependencies to Requires.private when --default-library=shared
1 participant