interpreter: set shared_library_only for default_library='shared'

Fixes #3970.
mesonbuild · Feb 11, 2025 · 1d54f32 · 1d54f32
1 parent df9b075
commit 1d54f32
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/mesonbuild/interpreter/interpreter.py b/mesonbuild/interpreter/interpreter.py
@@ -3327,7 +3327,9 @@ def build_library(self, node: mparser.BaseNode, args: T.Tuple[str, SourcesVararg
         default_library = self.coredata.get_option(OptionKey('default_library', subproject=self.subproject))
         assert isinstance(default_library, str), 'for mypy'
         if default_library == 'shared':
-            return self.build_target(node, args, T.cast('kwtypes.SharedLibrary', kwargs), build.SharedLibrary)
+            holder = self.build_target(node, args, T.cast('kwtypes.SharedLibrary', kwargs), build.SharedLibrary)
+            holder.shared_library_only = True
+            return holder
         elif default_library == 'static':
             return self.build_target(node, args, T.cast('kwtypes.StaticLibrary', kwargs), build.StaticLibrary)
         elif default_library == 'both':

diff --git a/test cases/unit/76 as link whole/meson.build b/test cases/unit/76 as link whole/meson.build
@@ -2,8 +2,8 @@ project('as-link-whole', 'c')
 
 foo = static_library('foo', 'foo.c', install: true)
 dep = declare_dependency(link_with: foo)
-bar1 = library('bar1', 'bar.c', dependencies: dep)
-bar2 = library('bar2', 'bar.c', dependencies: dep.as_link_whole())
+bar1 = static_library('bar1', 'bar.c', dependencies: dep)
+bar2 = static_library('bar2', 'bar.c', dependencies: dep.as_link_whole())
 
 # bar1.pc should have -lfoo but not bar2.pc
 pkg = import('pkgconfig')