CI: Cross compile Rust tests #11990
Open
CI: Cross compile Rust tests #11990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self.is_cross: | ||
| output_name += '_cross' | ||
| # Required for Windows, allowed everywhere else. | ||
| output_name += '.exe' |
There was a problem hiding this comment.
😂 How did this ever work? I was absolutely sure we ran rust tests on Windows, the toolchain is installed in run.ps1...
There was a problem hiding this comment.
I think we do: https://dev.azure.com/jussi0947/c10d67cb-aecc-4964-a931-a8b100dcbd57/_apis/build/builds/18167/logs/24. The .exe requirement could be only with wine maybe?
xclaesse
commented
Jul 14, 2023
xclaesse
force-pushed
the
rust-ci-cross
branch
3 times, most recently
from
33e4b52 to
8c92728
Compare
LingMan
reviewed
Jul 18, 2023
xclaesse
force-pushed
the
rust-ci-cross
branch
4 times, most recently
from
74d1aa1 to
566cc06
Compare
On Windows executables must have .exe suffix. On all other platforms .exe is allowed. Always use it, like clike compiler sanity check already does.
This fix running Windows executables that links to Rust STD both natively and under Wine, as well as in devenv.
rust: Require `native: true` for `proc-macro` targets and allow linking into targets for other platforms proc-macros are basically compiler extensions and must be compiled for the build machine so that the compiler can load and execute it at runtime. Without this, cross-compilation of targets that use proc-macro dependencies is going to fail. Fixes mesonbuild#11702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.