-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Rust Windows cross toolchain on ubuntu-rolling image #12015
Conversation
CI image updates must be merged before actually using it, otherwise CI still uses the old image. See #11990. |
CI failures don't make sense to me |
Building docker images has been failing for a while, @eli-schwartz fixed ubuntu-rolling recently which is the only one we care here. Fixing others would be great but unrelated to this PR. |
ubuntu-rolling did pass Rust tests successfully, so I think this PR is ready: https://github.com/mesonbuild/meson/actions/runs/5611071724/jobs/10266902617?pr=12015#step:5:1792. |
Cool. I say go ahead and merge it. |
Indeed, CI image updates are usually like this -- we only care about the specific job related to the image we are in the middle of updating.
In order for the tests to still pass on master, we just need a drop-in compatible replacement rustc, we are not actually running cross tests yet anyway -- so I agree, the success or failure of cross compile tests doesn't reflect on this PR. |
While working on this I noticed that's not exactly true, if rustc is missing those tests are happily skipped. |
Right, that's true... if the entire category is skipped because the tool isn't found at all then a single test skipping isn't considered an "unexpected skip" error. |
I don't think we need the docs or rustfmt, is it possible to exclude those? |
I think you want to add |
That worked locally, updated the PR to see how it goes. |
It worked, let's merge so I can use it in the other PR. |
No description provided.