Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Rust Windows cross toolchain on ubuntu-rolling image #12015

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

xclaesse
Copy link
Member

No description provided.

@xclaesse xclaesse requested a review from jpakkane as a code owner July 19, 2023 19:21
@xclaesse
Copy link
Member Author

CI image updates must be merged before actually using it, otherwise CI still uses the old image. See #11990.

@tristan957
Copy link
Contributor

CI failures don't make sense to me

@xclaesse
Copy link
Member Author

CI failures don't make sense to me

Building docker images has been failing for a while, @eli-schwartz fixed ubuntu-rolling recently which is the only one we care here. Fixing others would be great but unrelated to this PR.

@xclaesse
Copy link
Member Author

ubuntu-rolling did pass Rust tests successfully, so I think this PR is ready: https://github.com/mesonbuild/meson/actions/runs/5611071724/jobs/10266902617?pr=12015#step:5:1792.

@xclaesse xclaesse changed the title ci: Add Rust Windows cross toolchain on unbuntu-rolling image ci: Add Rust Windows cross toolchain on ubuntu-rolling image Jul 20, 2023
@tristan957
Copy link
Contributor

Cool. I say go ahead and merge it.

@eli-schwartz
Copy link
Member

Building docker images has been failing for a while, @eli-schwartz fixed ubuntu-rolling recently which is the only one we care here. Fixing others would be great but unrelated to this PR.

Indeed, CI image updates are usually like this -- we only care about the specific job related to the image we are in the middle of updating.

ubuntu-rolling did pass Rust tests successfully, so I think this PR is ready

In order for the tests to still pass on master, we just need a drop-in compatible replacement rustc, we are not actually running cross tests yet anyway -- so I agree, the success or failure of cross compile tests doesn't reflect on this PR.

@xclaesse
Copy link
Member Author

In order for the tests to still pass on master, we just need a drop-in compatible replacement rustc

While working on this I noticed that's not exactly true, if rustc is missing those tests are happily skipped.

@eli-schwartz
Copy link
Member

Right, that's true... if the entire category is skipped because the tool isn't found at all then a single test skipping isn't considered an "unexpected skip" error.

@eli-schwartz
Copy link
Member

info: default host triple is x86_64-unknown-linux-gnu
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: latest update on 2023-07-13, rust version 1.71.0 (8ede3aae2 2023-07-12)
info: downloading component 'cargo'
info: downloading component 'clippy'
info: downloading component 'rust-docs'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: downloading component 'rustfmt'
info: installing component 'cargo'
info: installing component 'clippy'
info: installing component 'rust-docs'
info: installing component 'rust-std'
info: installing component 'rustc'
info: installing component 'rustfmt'

I don't think we need the docs or rustfmt, is it possible to exclude those?

@tristan957
Copy link
Contributor

I think you want to add --profile minimal to the shell script invocation.

https://rust-lang.github.io/rustup/concepts/profiles.html

@xclaesse
Copy link
Member Author

--profile minimal --component clippy I guess?

That worked locally, updated the PR to see how it goes.

@xclaesse
Copy link
Member Author

It worked, let's merge so I can use it in the other PR.

@xclaesse xclaesse merged commit ded2204 into mesonbuild:master Jul 20, 2023
@xclaesse xclaesse deleted the ci-rustup branch July 20, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants