fix: tests, docs, examples, clippy #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples did not compile from what appears to be a change in naming a while back. Amends: b4ff36a
This can be expressed more clearly and explicit using `is_empty()`.
lwestlund
commented
Feb 2, 2025
lwestlund
force-pushed
the
fix/tests-docs-examples-clippy
branch
from
1af412e to
fb98e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some context to the changes: I am also adding support for hyprpaper IPC, but a lot of stuff was not working properly so I could not run
cargo testwithout knowing what I might have broken.This has a bit of overlap with #303 but I thought that I might as well fix all the things that I ran into. The only thing that I am not certain about is the same question as in that PR, whether the
/should be there in the test or not./should be in thetest_bindstest or not.Happy to split into more PR's if necessary, but reviewing by commit should hopefully be easy enough!