feat: add hyprpaper IPC #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These examples did not compile from what appears to be a change in naming a while back. Amends: b4ff36a
This can be expressed more clearly and explicit using `is_empty()`.
Only a cheap reference operation should be called `as_*`.
This allows rustfmt to be run separately, not relying on `Cargo.toml` for edition information.
lwestlund
force-pushed
the
feature/add-hyprpaper-ipc
branch
from
88b587f to
4e2cbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build on top of #309 to understand that I haven't broken anything and therefore has a lot of commits. The important one is the head commit that adds hyprpaper IPC through the
.hyprpaper.socksocket.Topics for discussion:
hyprpaper::Errorhave the variantsNoWallpapersActiveandNoWallpapersLoaded? Or should we in those cases return empty vectors instead to indicate that no wallpapers were active or loaded.