Fix react-hooks/exhaustive-deps error on Titlebar.tsx (#4273)

* Fix react-hooks/exhaustive-deps error on Titlebar.tsx * Release notes
actualbudget · Feb 19, 2025 · bf72a26 · bf72a26
1 parent 10c35e1
commit bf72a26
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -791,10 +791,6 @@ export default [
       'packages/desktop-client/src/components/sort.tsx',
       'packages/desktop-client/src/components/spreadsheet/useSheetValue.ts',
       'packages/desktop-client/src/components/table.tsx',
-      'packages/desktop-client/src/components/Titlebar.tsx',
-      'packages/desktop-client/src/components/transactions/MobileTransaction.jsx',
-      'packages/desktop-client/src/components/transactions/SelectedTransactions.jsx',
-      'packages/desktop-client/src/components/transactions/SimpleTransactionsTable.jsx',
       'packages/desktop-client/src/components/transactions/TransactionList.jsx',
       'packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
       'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',

diff --git a/packages/desktop-client/src/components/Titlebar.tsx b/packages/desktop-client/src/components/Titlebar.tsx
@@ -148,7 +148,7 @@ function SyncButton({ style, isMobile = false }: SyncButtonProps) {
     });
 
     return unlisten;
-  }, []);
+  }, [cloudFileId]);
 
   const mobileColor =
     syncState === 'error'

diff --git a/upcoming-release-notes/4273.md b/upcoming-release-notes/4273.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Fix react-hooks/exhaustive-deps error on Titlebar.tsx