Fix react-hooks/exhaustive-deps error on useAccounts.ts (#4262)

* Fix react-hooks/exhaustive-deps error on useAccounts.ts * Release notes
actualbudget · Feb 19, 2025 · 10c35e1 · 10c35e1
1 parent aea6e79
commit 10c35e1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -798,7 +798,7 @@ export default [
       'packages/desktop-client/src/components/transactions/TransactionList.jsx',
       'packages/desktop-client/src/components/transactions/TransactionsTable.jsx',
       'packages/desktop-client/src/components/transactions/TransactionsTable.test.jsx',
-      'packages/desktop-client/src/hooks/useAccounts.ts',
+      // 'packages/desktop-client/src/hooks/useAccounts.ts',
       'packages/desktop-client/src/hooks/useCategories.ts',
       'packages/desktop-client/src/hooks/useProperFocus.tsx',
     ],

diff --git a/packages/desktop-client/src/hooks/useAccounts.ts b/packages/desktop-client/src/hooks/useAccounts.ts
@@ -4,15 +4,18 @@ import { getAccounts } from 'loot-core/client/queries/queriesSlice';
 
 import { useSelector, useDispatch } from '../redux';
 
+import { useInitialMount } from './useInitialMount';
+
 export function useAccounts() {
   const dispatch = useDispatch();
   const accountsLoaded = useSelector(state => state.queries.accountsLoaded);
+  const isInitialMount = useInitialMount();
 
   useEffect(() => {
-    if (!accountsLoaded) {
+    if (isInitialMount && !accountsLoaded) {
       dispatch(getAccounts());
     }
-  }, []);
+  }, [accountsLoaded, dispatch, isInitialMount]);
 
   return useSelector(state => state.queries.accounts);
 }
diff --git a/upcoming-release-notes/4262.md b/upcoming-release-notes/4262.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Fix react-hooks/exhaustive-deps error on useAccounts.ts