Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0, electron_34-bin: fix read out of range on aarch64 16k pages systems #382813

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 17, 2025

Bot-based backport to release-24.11, triggered by a label in #382497 and then manually pushed parts of #382361.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

Previously in chromium (source build): 608b73b

This works around a regression in chromium M131-134 that causes electron
v33 and v34 on aarch64-linux with 16k pagesize (e.g. Asahi Linux) to
crash.

This commit applies this workaround only to electron v34, as v33.4.1,
for which we have a soon to be merged PR open, already carries the
workaround upstream.

(cherry picked from commit 69bab47)
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 17, 2025
@nix-owners nix-owners bot requested review from teutat3s and yayayayaka February 17, 2025 13:09
@emilylange emilylange changed the title [Backport release-24.11] electron_34-bin: fix read out of range on aarch64 16k pages systems [Backport release-24.11] electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0, electron_34-bin: fix read out of range on aarch64 16k pages systems Feb 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 17, 2025
@emilylange
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382813


x86_64-linux

✅ 85 packages built:
  • affine
  • antares
  • antimatter-dimensions
  • appium-inspector
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • chatd
  • drawio
  • drawio-headless
  • electron (electron_33)
  • electron-bin (electron_33-bin)
  • electron-chromedriver (electron-chromedriver_33)
  • electron-chromedriver_32
  • electron-chromedriver_34
  • electron_32
  • electron_32-bin
  • electron_34 (electron_34-bin)
  • element-desktop
  • equibop
  • fcast-receiver
  • feishin
  • follow
  • freetube
  • gfn-electron
  • goofcord
  • headset
  • heroic
  • heroic-unwrapped
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kuro
  • legcord
  • mattermost-desktop
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • pocket-casts
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python311Packages.mkdocs-drawio-exporter
  • python311Packages.mkdocs-drawio-exporter.dist
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sharedown
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • webcord
  • webcord-vencord
  • webtorrent_desktop
  • yandex-music
  • youtube-music
  • ytdownloader
  • ytmdesktop
  • zulip

@emilylange emilylange merged commit 85142e3 into release-24.11 Feb 17, 2025
42 of 44 checks passed
@emilylange emilylange deleted the backport-382497-to-release-24.11 branch February 17, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants