Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0 #382361

Merged
merged 9 commits into from
Feb 17, 2025
Merged

electron{-source,-bin,-chromedriver}: 32.3.0 -> 32.3.1, 33.4.0 -> 33.4.1, 34.1.1 -> 34.2.0 #382361

merged 9 commits into from
Feb 17, 2025

Conversation

emilylange
Copy link
Member

@emilylange emilylange commented Feb 15, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@emilylange
electron_32-bin: 32.3.0 -> 32.3.1
e9e8085 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1
@emilylange
electron_33-bin: 33.4.0 -> 33.4.1
51a2d75 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1
@emilylange
electron_34-bin: 34.1.1 -> 34.2.0
00f656d 
- Changelog: https://github.com/electron/electron/releases/tag/v34.2.0
- Diff: electron/electron@refs/tags/v34.1.1...v34.2.0
@emilylange
electron-source.electron_32: 32.3.0 -> 32.3.1
6b1989f 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1
@emilylange
electron-source.electron_33: 33.4.0 -> 33.4.1
003f8f4 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1
@emilylange
electron-chromedriver_32: 32.3.0 -> 32.3.1
4b382b0 
- Changelog: https://github.com/electron/electron/releases/tag/v32.3.1
- Diff: electron/electron@refs/tags/v32.3.0...v32.3.1
@emilylange
electron-chromedriver_33: 33.4.0 -> 33.4.1
85c576b 
- Changelog: https://github.com/electron/electron/releases/tag/v33.4.1
- Diff: electron/electron@refs/tags/v33.4.0...v33.4.1
@emilylange
electron-chromedriver_34: 34.1.1 -> 34.2.0
6dc8694 
- Changelog: https://github.com/electron/electron/releases/tag/v34.2.0
- Diff: electron/electron@refs/tags/v34.1.1...v34.2.0
@emilylange emilylange added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 Backport PR automatically labels Feb 15, 2025
teutat3s
teutat3s reviewed Feb 15, 2025
View reviewed changes
Copy link
Member

@teutat3s teutat3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this bump. The commit for the electron-source 34 version bump is currently missing.

@emilylange
electron_32: fix log spam when building on x86_64-linux as well
3f514d3 
Follow-up to ce04dc5.

Turns out the very same log spam is happening on x86_64-linux and not
just on aarch64-linux but hydra.nixos.org does not enforce the log limit
of 64mb for some reason.

I should have figured.
@emilylange
Copy link
Member Author

The commit for the electron-source 34 version bump is currently missing.

We don't build electron_34 from source (yet?) :)

@teutat3s
Copy link
Member

Oops my bad. That explains it (:

@emilylange emilylange mentioned this pull request Feb 16, 2025
Merged
13 tasks
@emilylange
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 382361

x86_64-linux

❌ 2 packages failed to build:
  • follow
  • sharedown
✅ 97 packages built:
  • affine
  • affine-bin
  • antares
  • antimatter-dimensions
  • anytype
  • appium-inspector
  • bilibili
  • bitwarden-desktop
  • bitwarden-directory-connector
  • blockbench
  • bruno
  • camunda-modeler
  • caprine
  • catalyst-browser
  • chatd
  • deltachat-desktop
  • drawio
  • drawio-headless
  • electron (electron-bin, electron_34, electron_34-bin)
  • electron-chromedriver (electron-chromedriver_34)
  • electron-chromedriver_32
  • electron-chromedriver_33
  • electron_32
  • electron_32-bin
  • electron_33
  • electron_33-bin
  • element-desktop
  • equibop
  • fcast-receiver
  • feishin
  • freetube
  • gdlauncher-carbon
  • gfn-electron
  • gitify
  • goofcord
  • google-chat-linux
  • headset
  • heroic
  • heroic-unwrapped
  • httptoolkit
  • itch
  • jitsi-meet-electron
  • kando
  • koodo-reader
  • kuro
  • legcord
  • lx-music-desktop
  • marktext
  • mattermost-desktop
  • morgen
  • mqtt-explorer
  • nix-tour
  • obsidian
  • open-stage-control
  • openfortivpn-webview
  • pandoc-drawio-filter
  • pandoc-drawio-filter.dist
  • penpot-desktop
  • pocket-casts
  • podman-desktop
  • pritunl-client
  • proton-pass
  • protonmail-desktop
  • python312Packages.mkdocs-drawio-exporter
  • python312Packages.mkdocs-drawio-exporter.dist
  • python313Packages.mkdocs-drawio-exporter
  • python313Packages.mkdocs-drawio-exporter.dist
  • r2modman
  • redisinsight
  • revolt-desktop
  • ride
  • sieve-editor-gui
  • siyuan
  • standardnotes
  • stretchly
  • super-productivity
  • teams-for-linux
  • terra-station
  • tetrio-desktop
  • thedesk
  • threema-desktop
  • trilium-next-desktop
  • uhk-agent
  • uhk-udev-rules
  • uivonim
  • vesktop
  • vieb
  • voicevox
  • webcord
  • webcord-vencord
  • webtorrent_desktop
  • yandex-music
  • youtube-music
  • ytdownloader
  • ytmdesktop
  • zepp-simulator
  • zulip

follow and sharedown failures are unrelated.

@teutat3s teutat3s added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 16, 2025
@emilylange emilylange merged commit 946fe2a into NixOS:master Feb 17, 2025
45 checks passed
@emilylange emilylange deleted the electron branch February 17, 2025 13:01
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 17, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-382361-to-release-24.11 origin/release-24.11
cd .worktree/backport-382361-to-release-24.11
git switch --create backport-382361-to-release-24.11
git cherry-pick -x e9e80851ca89e5c5f956a767bd88e1e59b8e2e08 51a2d757f843d1f6222f5c5597c5dd555ecc9149 00f656d209ad81944f20c1346b1d3e0a9fa3fc89 6b1989f61a4fa7417596073bcd37dcafc14bff11 003f8f4024c02246c7b6941a05d14a89f487dfd5 4b382b0464d8ab5dec60b46004c55b48dc7b5af7 85c576ba9b799ed349a68d3305f675a57de5620e 6dc8694a88e65a8ff721722695aad026709974ab 3f514d36a7c353152c22e72a36f1edd2f4b7c960

@emilylange
Copy link
Member Author

Backport fails due to 3f514d3.

Will stack the remaining commits onto #382813, given I intend to merge them together anyway.

@emilylange emilylange mentioned this pull request Feb 17, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teutat3s teutat3s teutat3s approved these changes

@liam-murphy14 liam-murphy14 liam-murphy14 approved these changes

@yayayayaka yayayayaka Awaiting requested review from yayayayaka

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilylange @teutat3s @liam-murphy14