Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] Fail GHA eval on non-empty stderr #382099

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[Backport release-24.11] Fail GHA eval on non-empty stderr #382099

merged 2 commits into from
Feb 14, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Feb 14, 2025 •
edited by wolfgangwalther
Loading

Bot-based backport to release-24.11, triggered by a label in #381266.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@infinisil @github-actions
ci/eval: Refactor to cleanly separate stderr
1199390 
Previously stderr was mixed with the time stats

This allows checking stderr in the next commit

(cherry picked from commit 0344bd7)
@infinisil @github-actions
ci/eval: Fail on non-empty stderr
dccd2b7 
Just like the channel eval requires.

(cherry picked from commit 7c62a76)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 14, 2025
Merged
1 task
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Feb 14, 2025
@wolfgangwalther wolfgangwalther merged commit 628d2d6 into release-24.11 Feb 14, 2025
21 of 24 checks passed
@nix-owners nix-owners bot requested a review from infinisil February 14, 2025 17:06
@wolfgangwalther wolfgangwalther deleted the backport-381266-to-release-24.11 branch February 14, 2025 17:06
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philiptaron philiptaron Awaiting requested review from philiptaron

@risicle risicle Awaiting requested review from risicle

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@mweinelt mweinelt Awaiting requested review from mweinelt

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfgangwalther @infinisil