Fail GHA eval on non-empty stderr #381266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously stderr was mixed with the time stats This allows checking stderr in the next commit
Just like the channel eval requires.
github-actions
bot
added
6.topic: continuous integration
nix-owners
bot
requested review from
philiptaron,
risicle,
LeSuisse and
mweinelt
github-actions
bot
added
10.rebuild-darwin: 0
1 task
|
I ran this 3 times:
As expected when those warnings show up, it errors out. The warnings are visible in the log output, too. It does what it says! |
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the GHA eval fail when stderr isn't empty, closing #371223.
Things done
This work is funded by Tweag and Antithesis ✨
Add a 👍 reaction to pull requests you find important.