python312Packages.cramjam: 2.8.3 -> 2.9.1 #378691
Open
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
veprbl
reviewed
Feb 5, 2025
| "--no-default-features" | ||
| "--features" | ||
| # default features from Cargo.toml, modified to specify -shared | ||
| "extension-module,snappy,lz4,bzip2,brotli,xz,zstd,gzip,zlib,deflate,blosc2-shared,use-system-isal-shared,igzip-shared,ideflate-shared,izlib-shared,use-system-blosc2-shared" |
There was a problem hiding this comment.
Those marked with -shared here become experimental/optional on the master. Maybe, we don't need to ship those. Why xz and others don't need to be -shared?
There was a problem hiding this comment.
Oh, you are right that they are disabled by default now. I suppose we can do that for this version already.
About xz and the others, I'm not 100% sure. Maybe they are always shared. I'll check.
dotlambda
reviewed
Feb 10, 2025
| }; | ||
|
|
||
| cargoDeps = rustPlatform.fetchCargoVendor { | ||
| inherit src; | ||
| hash = "sha256-Gpj/LUCx/ivYlmxNJnEZr8caEfV4OaQwEPNjz7vobsw="; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
Suggested change
| name = "${pname}-${version}"; | |
| inherit pname version; |
That is exactly the point of this update (according to #373327) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting staging-next to avoid merge conflicts
Things done