python312Packages.cramjam: 2.8.3 -> 2.9.1-unstable-2025-01-04 #381445
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @niklaskorz for helping me with the library linking. |
niklaskorz
reviewed
Feb 12, 2025
niklaskorz
reviewed
Feb 12, 2025
GaetanLepage
force-pushed
the
cramjam
branch
from
6850b47 to
8138080
Compare
niklaskorz
reviewed
Feb 12, 2025
| buildInputs = lib.optional stdenv.hostPlatform.isDarwin libiconv; | ||
| buildInputs = [ | ||
| c-blosc2 | ||
| isa-l |
There was a problem hiding this comment.
Suggested change
| isa-l | |
| ] ++ lib.optionals (stdenv.hostPlatform.system != "aarch64-darwin") [ | |
| # broken on aarch64-darwin, but not on x86_64-darwin | |
| isa-l |
| # Do not build those libraries from source. Use the nixpkgs ones instead. | ||
| maturinBuildFlags = [ | ||
| "--features=use-system-blosc2-shared" | ||
| "--features=use-system-isal-shared" |
There was a problem hiding this comment.
Suggested change
| "--features=use-system-isal-shared" | |
| ] ++ lib.optionals (stdenv.hostPlatform.system != "aarch64-darwin") [ | |
| "--features=use-system-isal-shared" |
There was a problem hiding this comment.
I'm not sure that this feature can be disabled.
At least, this is not the way. This only says to isal-sys to not compile isa-l from source, but use the system version.
Removing this flag leads to the build.rs script attempting to build isa-l from source.
There was a problem hiding this comment.
Hm, ISA shouldn't be enabled by default if I read the Cargo.toml correctly. The ISA features are part of the experimental feature set, not the default: https://github.com/milesgranger/cramjam/blob/61564e7761e38e5ec55e7939ccd6a276c2c55d11/Cargo.toml#L17-L18
There was a problem hiding this comment.
As discussed in #378691, those are experimental/optional on master, so we could already disable them for the release version.
GaetanLepage
force-pushed
the
cramjam
branch
5 times, most recently
from
9317312 to
ef3cc08
Compare
1 task
GaetanLepage
force-pushed
the
cramjam
branch
from
ef3cc08 to
7cc9c19
Compare
GaetanLepage
force-pushed
the
cramjam
branch
from
7cc9c19 to
36acd90
Compare
|
In the end the |
|
veprbl
reviewed
Feb 13, 2025
GaetanLepage
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Fix and update
cramjam.Changelog: https://github.com/milesgranger/cramjam/releases/tag/v2.9.1
cc @veprbl
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.