Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator does not return kind #353

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

cr-EliasJunior
Copy link
Contributor

This is a follow up from https://github.com/yoshidan/google-cloud-rust/pull/336/files

The emulator seems to not return kind on any of the responses. In the original PR this was fixed by adding a serde(default) to those fields on the responses. While testing the library with client.query::<Row>(&project_id, request).await? I discovered there was a missing place.

@yoshidan yoshidan added the safe to test safe to test label Feb 10, 2025
@yoshidan
Copy link
Owner

Thank you for your contribution.

@yoshidan yoshidan merged commit e0f941f into yoshidan:main Feb 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants