Support moving an object #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 16, 2024 23:36
added 3 commits
July 17, 2024 00:07
|
Hi @yoshidan - do you have any comments on this PR? Is it fit for being merged? |
yoshidan
reviewed
Jul 18, 2024
storage/src/http/storage_client.rs
Outdated
| let copy_req: CopyObjectRequest = req.clone().into(); | ||
| let delete_req: DeleteObjectRequest = req.clone().into(); | ||
| let copy_result = self.copy_object(©_req).await; | ||
| let result = if copy_result.is_ok() { |
There was a problem hiding this comment.
Early returns reduce the number of conditional branches.
let copy_result = self.copy_object(©_req).await?;
let _ = self.delete_object(&delete_req).await?;
Ok(copy_result)There was a problem hiding this comment.
Thanks @yoshidan , I have actioned it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://cloud.google.com/storage/docs/copying-renaming-moving-objects#permissions-rest
Google provides SDK and CLI command for moving a file, which is basically a
copycommand followed bydelete.This PR provides a
movefunction that wrapscopyanddeletefunction and simulates a move.Thus, providing a single function for library users emulating a
move, instead of they implementing it repeatedly.