OpenSSL Compat Layer: OCSP response improvments #8408
+3,014
−382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizlik
force-pushed
the
ocsp-resp-refactor
branch
3 times, most recently
from
3b89ce4 to
f96acbb
Compare
rizlik
force-pushed
the
ocsp-resp-refactor
branch
3 times, most recently
from
43964c1 to
2816d92
Compare
rizlik
force-pushed
the
ocsp-resp-refactor
branch
from
2816d92 to
a635189
Compare
|
retest this please |
julek-wolfssl
requested changes
Feb 4, 2025
julek-wolfssl
requested changes
Feb 4, 2025
julek-wolfssl
requested changes
Feb 4, 2025
julek-wolfssl
requested changes
Feb 4, 2025
|
retest this please |
rizlik
force-pushed
the
ocsp-resp-refactor
branch
from
a92d921 to
b02a263
Compare
|
retest this please |
julek-wolfssl
requested changes
Feb 5, 2025
|
retest this please |
- search for the signer in the CertificateManager if the embedded cert verification fails in original asn template.
- Added a new test case `resp_bad_embedded_cert` in `create_ocsp_test_blobs.py` to test OCSP response with an unusable internal cert that can be verified in Cert Manager. - Updated `test_ocsp_response_parsing` in `ocsp.c` to include the new test case. - Ensured the new test case checks for proper handling of OCSP responses with incorrect internal certificates.
rizlik
force-pushed
the
ocsp-resp-refactor
branch
from
da504fa to
1eecf32
Compare
|
retest this please |
dgarske
requested changes
Feb 17, 2025
| @@ -2737,6 +2748,12 @@ struct OcspResponse { | |||
| byte* response; /* Pointer to beginning of OCSP Response */ | |||
| word32 responseSz; /* length of the OCSP Response */ | |||
|
|
|||
| enum responderIdType responderIdType; | |||
There was a problem hiding this comment.
Does this new union need to always be part of the OcspResponse structure or can it be just with compatibility enabled? I am worried about struct size growth on stack.
There was a problem hiding this comment.
It's always needed. If stack size is a concern I can refactor the code to use heap memory instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves of OCSP response handling.
Aligns wolfSSL_OCSP_basic_verify and wolfSSL_d2i_OCSP_RESPONSE to OpenSSL behavior.
Replaces #8036