transcripts: Reset error state for all blocks #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, once there was an `:error` (or `:bug`) block, all following blocks would behave as if they had had an error. Except `ucm` blocks would correctly reset the state so that following blocks would behave correctly again. This moves the state reset to be shared by all blocks. Fixes unisonweb#5575.
aryairani
approved these changes
Feb 13, 2025
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously, once there was an
:error(or:bug) block, all following blocks would behave as if they had had an error. Exceptucmblocks would correctly reset the state so that following blocks would behave correctly again.This moves the state reset to be shared by all blocks.
Fixes #5575.
Test coverage
There’s a new transcript specifically for this issue. There was also another transcript that had an incorrect
:errorthat worked around this bug.