Adds FromJSON instances to enable Share Persistent JSON caching. #5576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready, but CI is failing due to binary caches so it's hard to tell |
ChrisPenner
commented
Feb 11, 2025
| @@ -329,10 +329,21 @@ instance ToCapture (Capture "namespace" Path.Path) where | |||
| "E.g. base.List" | |||
|
|
|||
| instance ToJSON Path.Path where | |||
| toJSON p = Aeson.String (tShow p) | |||
There was a problem hiding this comment.
Using Show in a ToJSON kinda makes me nervous, so I found the explicit combinator it was calling.
2 tasks
ChrisPenner
force-pushed
the
cp/json-caching
branch
from
61b3e62 to
5df30e1
Compare
aryairani
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I'm adding a persistent caching layer for JSON values on Share, see unisoncomputing/share-api#35
, and for that we need to be able to round-trip a bunch of stuff that previously only needed to be rendered.
This adds the matching FromJSON instances for types which previously only had ToJSON.
Implementation notes
Adds FromJSON instances.
Interesting/controversial decisions
Nope
Test coverage
I tested roundtripping Term Definitions and rendered docs in Share here: unisoncomputing/share-api#35