Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show full names in dependents output #5573

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

mitchellwrosen
Copy link
Member

@mitchellwrosen mitchellwrosen commented Feb 6, 2025

Overview

This PR modifies dependents to show fully-qualified names instead of suffixified names.

However, I wonder if we should go a little further, and render the names something like this, showing both the fully-qualified name and its shortest unique suffix:

Screen Shot 2025-02-06 at 12 52 55 PM

@aryairani / @ceedubs WDTY?

Still to do: dependencies command

@ceedubs
Copy link
Contributor

ceedubs commented Feb 6, 2025

Nice thanks @mitchellwrosen!

I like the grayed-out prefix! I'd say it's a nice bonus; if it is much work either for you or ucm then I wouldn't worry about it much.

@mitchellwrosen
Copy link
Member Author

It's not much work!

@mitchellwrosen
Copy link
Member Author

@aryairani any thoughts on this?

@aryairani
Copy link
Contributor

Sorry I didn't see this, and normally only scan over non-draft PRs. I like it too if it's easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants