Simplify Stack usage in Nix #5486
Draft
+101
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft
sellout
force-pushed
the
simplify-nix-flake
branch
2 times, most recently
from
a7551ef to
4b71041
Compare
aryairani
approved these changes
Dec 7, 2024
sellout
force-pushed
the
simplify-nix-flake
branch
from
4b71041 to
cee4f47
Compare
ceedubs
approved these changes
Dec 11, 2024
There were two Nixpkgs inputs, with one being used solely to get a particular version of Stack. This now “compromises” on the same release of Nixpkgs as used for Stack, but from the haskell.nix project to have a consistent package set. There are also a few other version bumps here (because once you change an uncached input, you might as well upgrade everything): - bump LTS to 22.43 (GHC 9.6.6 from 9.6.5) - bump HLS to 2.9 (this is now transitively included via the haskell.nix input) - bump hpack to 0.36.0 (this is actually the minimum bound for the version of Stack we use, so the previous setting was inconsistent)
These were out of sync with the intended version (specified in .vscode/settings.json).
Somewhat described at https://github.com/nix-systems/nix-systems This is useful for Haskell projects, because commands like ```bash nix flake show --allow-import-from-derivation ``` can often fail, complaining that it can’t find some other architecture to build on. With nix-systems, you can append `--override-input systems github:nix-systems/x86_64-linux` to the command to ensure that x86_64-linux is the only platform in play.
It is not triggering a(nother) rebuild of GHC.
This workaround required another local workaround. If you had a line like `LD_LIBRARY_PATH=` in your .envrc, it can be removed now.
sellout
force-pushed
the
simplify-nix-flake
branch
from
a9dc70a to
dc8561f
Compare
|
Well, this is annoying – I updated the cache, but the Ubuntu build is still failing with OOM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The particular Stack build was the only reason we had two Nixpkgs dependencies. This removes the custom stack dependency, and instead sets the versions for the haskell.nix
tools.It also bumps hpack to 0.36.0, because it turns out that’s the minimum required by our pinned version of Stack anyway.