Prevent activity overlap when toggling "Show Unified Inbox" #8847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8767
Description:
This PR fixes the issue where toggling the "Show Unified Inbox" setting causes activity overlap and inconsistent UI updates. As described in my comment on #8767, the problem occurs because ActivityCompat.recreate() adds a new instance of MessageList to the back stack without clearing the previous one, leading to "ghost" activities when navigating back.
Changes:
Replaced ActivityCompat.recreate() with a new recreateMessageList() function that uses Intent with FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_CLEAR_TASK to ensure a clean activity launch.
Testing:
Verified both scenarios: enabling and disabling "Show Unified Inbox".
Confirmed that pressing the back button now closes the app or returns to the previous screen without overlapping activities.