Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration admin color-coded sections/buttons #10887

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kr-matthews
Copy link
Contributor

@kr-matthews kr-matthews commented Feb 20, 2025

My intention was to change the yellow color (since contrast isn't good enough with white text) and improve the button UI on mobile, but then this happened. I'll improve the buttons next.

  • Reorder action buttons to the same order as the tables.
  • Adjust the colors (and some icons) of these buttons.
  • Add colors to the tables & section headers too, to make it easier to find sections at a glance, and to easily see which table you're in mid-table.
  • Disable the missing button instead of hiding it, when only 1 registration is selected.

0
1
2
3
4
5

These are the available colors. I didn't use brown because the light version (which appears in the left column of the table) looks the same as the light version of orange.

image

If the section headers are too much, then just coloring the text is another option. Or keeping them black, but then you can't see the color at all when collapsed.

alt-header

It's also possible to color the entire table, but I think that's way too much:

alt-table

Preview of next PR - grouping action buttons into a dropdown:

next

@kr-matthews kr-matthews self-assigned this Feb 20, 2025
@gregorbg
Copy link
Member

I love it! As far as my personal taste goes, I think coloring the headers is a bit too much. But I definitely want more opinions on this change, as this is not a matter that I have "jurisdiction" over. (But I do agree that fully coloring the tables is way too much 😂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants