Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registered_at timestamp #10873

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dunkOnIT
Copy link
Contributor

@dunkOnIT dunkOnIT commented Feb 18, 2025

Notes:

Everything here seems to work, the main question I have is when to populate registered_at - I see two options:

  1. Time at which the reg request was submitted?
  • Just because someone submits a request doesn't mean they've registered
  1. Current time at the point of creating the registration?
  • This is what I intuitively want to use, but then: Why are we not using created_at with an increased precision value?

Until we have an answer to this, I'm using a very direct approach - getting the db to populate registered_at when the row is created. I don't love this approach, because it isn't exposed in the code/editable later - but something like an after_create hook feels very redundant (given that we have created_at) with my current understanding, so I just went with something simple while we discuss the implementation.

TODO

  • Add & populate migration
  • Populate registered_at when reg is created
  • Display registered_at in the frontend

@dunkOnIT dunkOnIT marked this pull request as ready for review February 18, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants