WCA Live: Add small pulse loader icon for WebSocket connection status #10835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
feature/wca-live-connection-pulse
branch
from
0351325 to
6e7ee74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little late night fun :D
Bildschirmaufnahme_20250214_215900.webm
The circle actually changes color and stops pulsating when the Socket gets disconnected for any reason:
Bildschirmaufnahme_20250214_220235.webm
Unfortunately ActionCable does not expose any actual error information, that means we cannot show the user why the connection broke away. But the transition itself is fully automatic!
In terms of reviewing, there is a boolean toggle looping between true and false. That is because in SemUI, unidirectional transitions (transitions that do not make a clear distinction between "on" and "off", they "just play") do not differentiate between
trueandfalse. They just play the animation whenever thevisiblevalue changes: https://react.semantic-ui.com/modules/transition/#explorers-transition-explorer