Refactor Form.RichText component to use Quill #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamie-n
requested review from
kishannareshpal,
ianvexler,
jsteeland and
rich-williamson
as code owners
|
@kishannareshpal are you able to offer any input on what's going on with the |
|
What's happening with this branch? It looks super old? |
|
This can likely be closed - this PR was for the tasks project but the UI components are now baked into that repo instead. Do you agree @Jamie-n? |
Yeah I agree, this PR can be closed. The features and changes within this branch are now included directly in the tasks project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor FormRichText to use
quillinstead ofreact-quillto enable us to use the mention plugin as this isn't supported byreact-quill.Caution
Due to an ongoing issue, anything using this package will have to directly import the
FormRichTextcomponent and use it as<FormRichText>rather than<Form.RichText>.The
onChangehandler has also changed and will not be compatible with directly injecting states into the prop, instead(value) => setFoo(value)will need to be used.