Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This feature adds a
.is_skip_logger
flag to the Log PluginBuilder
, askip_logger()
method to theBuilder
, and logic to avoid acquiring (creating) a logger and attaching it to the global logger. Sinceacquire_logger
ispub
, aLoggerNotInitialized
is added and returned if it's called when theis_skip_looger
flag is set.Why
This permits a crude BYO logging implementation as it avoids
attach_logger
. I have tracing setup withtracing-log
and would just prefer to send the logs there. Additionally, without this change, you cannot create multiple Tauri mock apps for testing. Additionally, the end user can handle the logger but still use the plugin for easy access to the command and JS.Please let me know if you do not think this approach is useful or if you would like me to make changes. Thanks!