Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shell for spawning swaybar #7023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use shell for spawning swaybar #7023

wants to merge 1 commit into from

Conversation

kraftwerk28
Copy link
Contributor

This adds ability to set any command in swaybar_command, not just path to binary, which is default behavior in i3.

@emersion emersion added the i3-compat Sway doesn't match i3's behavior label May 24, 2022
@emersion
Copy link
Member

Nit: exec swaybar would be a better default command, because it replaces the sh process.

@kraftwerk28 kraftwerk28 force-pushed the swaybar-command-shell branch from 8dfea9c to b61cc3f Compare May 24, 2022 19:58
Nefsen402
Nefsen402 reviewed May 25, 2022
View reviewed changes
@kraftwerk28 kraftwerk28 force-pushed the swaybar-command-shell branch 2 times, most recently from a0b8f63 to bb8eba2 Compare May 26, 2022 07:37
@kraftwerk28 kraftwerk28 force-pushed the swaybar-command-shell branch from bb8eba2 to 0b89b37 Compare June 1, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nefsen402 Nefsen402 Nefsen402 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
i3-compat Sway doesn't match i3's behavior
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraftwerk28 @emersion @Nefsen402