chore: disable removeTitle from default plugins #2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Title
This has been on the to-do list for a while, but was considered a breaking change.
The removeTitle plugin is problematic because it removes core accessibility features. Consider the following example:
The Docusuaurs logo and PostCSS logo are actually linked to the respective projects websites. A screen reader can read what these links are out loud, for example, when the user focuses on them by pressing tab.
However, before disabling removeTitle, the screen reader would only read "Link", that's it. Not what the link was, but only "Link". This is not a positive user experience.
After disabling the removeTitle plugin, the screen reader now reads "Docusaurus, Link" and "PostCSS, Link" respectively.
SVGO should not discriminate against users with impairments by default. Accessibility is more important that optimization.
Other projects like Docusaurus and SVGR already disable this by default, so it's actually a more common setup already amongst our installs.
Chores