Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable removeTitle from default plugins #2014

Merged
merged 4 commits into from
May 24, 2024

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 24, 2024

Remove Title

This has been on the to-do list for a while, but was considered a breaking change.

The removeTitle plugin is problematic because it removes core accessibility features. Consider the following example:

The SVGO website, focused on the Integrations section, which featured two links.

https://svgo.dev/

The Docusuaurs logo and PostCSS logo are actually linked to the respective projects websites. A screen reader can read what these links are out loud, for example, when the user focuses on them by pressing tab.

However, before disabling removeTitle, the screen reader would only read "Link", that's it. Not what the link was, but only "Link". This is not a positive user experience.

After disabling the removeTitle plugin, the screen reader now reads "Docusaurus, Link" and "PostCSS, Link" respectively.

SVGO should not discriminate against users with impairments by default. Accessibility is more important that optimization.

Other projects like Docusaurus and SVGR already disable this by default, so it's actually a more common setup already amongst our installs.

Chores

  • Makes few other amendments so the docs reflect that removeViewBox and removeTitle are disabled.
  • Deletes the outdated changelog which is no longer needed in this repository.

@SethFalco SethFalco changed the title Revise plugins chore: disable removeTitle as default plugin May 24, 2024
@SethFalco SethFalco changed the title chore: disable removeTitle as default plugin chore: disable removeTitle from default plugins May 24, 2024
@SethFalco SethFalco merged commit c86536e into svg:main May 24, 2024
10 checks passed
@SethFalco SethFalco deleted the revise-plugins branch May 25, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant