Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate video settings to realm and remove video settings service. #5285

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Migrate video settings to realm and remove video settings service. #5285

wants to merge 12 commits into from

Conversation

michelinewu
Copy link
Contributor

No description provided.

@michelinewu michelinewu added the needs QA requires QA testing on the branch before merging label Jan 21, 2025
@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 21, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ renderer.(hash).js
 7.07MB (-2.37KB -0.03%) -
Unchanged files (3)
Status Path Size Limits
✅ vendors~renderer.(hash).js
 4.67MB -
✅ updater.js
 115.29KB -
✅ guest-api.js
 40.19KB -

Total files change -2.37KB -0.02%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@michelinewu michelinewu marked this pull request as ready for review February 6, 2025 14:09
@michelinewu michelinewu removed the needs QA requires QA testing on the branch before merging label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gettinToasty gettinToasty Awaiting requested review from gettinToasty

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michelinewu