-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds targets for building StarGenerator interface code. #14
Open
jdbrice
wants to merge
53
commits into
star-bnl:master
Choose a base branch
from
jdbrice:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d include dirs (not desirable) and builds as 3 sep libs instead of one
Just wanted to check on this... I know this is low priority, but do you have any suggestion for the first and second bullets? Maybe with some direction I can work out details. |
Will have a closer look today for sure... Just need some more time to review |
Add switch to turn tree on and off
Start some cleanup
…nderstand slowdowns and geometry issues
…k you Jason for basic code
…imulation. Remove dependency on StarGenerator for now.
…s, compute sTGC covmat in StgMaker
…cov mat in TrackFitter, StgMaker, default to GEANT hits if StEvent is not available
… from in memory geom. small improvement in pt res
other cleanup and loose changes from directory change and name change
…d inclusion of Ftt/Fst
…p incorrectly after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes bare minimum targets for building essential StarGenerator code
A couple of undesirable things:
Note: I tested this inside the starbnl/star-sw:latest-build but within that image I dont see anything in /home/ - i.e. I dont see any evidence that ccache is there. Should it be there in this image?