Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds targets for building StarGenerator interface code. #14

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

jdbrice
Copy link

@jdbrice jdbrice commented Feb 14, 2020

Includes bare minimum targets for building essential StarGenerator code

A couple of undesirable things:

  • Uses include paths from the install dir (because I could not find tables/g2t/* headers and a few other i the build dir)
  • Builds 3 separate libs instead of a single "libStarGenerator.so"
  • I left out StarGenerator/Kinematics which would be nice. I left it out since it depends on BOOST (it uses exactly one function, boost::split from string.hpp in a few places). If possible I'd like to write a patch that removes the BOOST dependency (replace the offending line with a stl equivalent) but I dont know how to use the patch well enough yet. But this is not a big deal, since this module doesn't add anything new, just wraps functionality for convenience.

Note: I tested this inside the starbnl/star-sw:latest-build but within that image I dont see anything in /home/ - i.e. I dont see any evidence that ccache is there. Should it be there in this image?

@jdbrice
Copy link
Author

jdbrice commented Feb 28, 2020

Just wanted to check on this... I know this is low priority, but do you have any suggestion for the first and second bullets? Maybe with some direction I can work out details.

@plexoos
Copy link
Member

plexoos commented Feb 28, 2020

Will have a closer look today for sure... Just need some more time to review

Daniel added 25 commits March 3, 2020 09:10
Add switch to turn tree on and off
…imulation. Remove dependency on StarGenerator for now.
…cov mat in TrackFitter, StgMaker, default to GEANT hits if StEvent is not available
Daniel added 25 commits July 31, 2020 17:05
… from in memory geom. small improvement in pt res
other cleanup and loose changes from directory change and name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants