feat: add config option to unset

Signed-off-by: KAS <[email protected]>
spaceness · Jan 17, 2025 · 7b77d27 · 7b77d27
1 parent aa822dd
commit 7b77d27
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/apps/daemon/schema.json b/apps/daemon/schema.json
@@ -96,6 +96,10 @@
     "SessionConfig": {
       "additionalProperties": false,
       "properties": {
+        "hideVncPassword": {
+          "description": "Unsets $VNCPASSWORD inside a container to make the password harder to get.",
+          "type": "boolean"
+        },
         "vncPassword": {
           "description": "Default VNC password to use. Defaults to randomly generated.",
           "type": "string"

diff --git a/apps/daemon/src/lib/config/types.d.ts b/apps/daemon/src/lib/config/types.d.ts
@@ -68,4 +68,8 @@ export interface SessionConfig {
 	 * Default VNC password to use. Defaults to randomly generated.
 	 */
 	vncPassword?: string;
+	/**
+	 * Unsets $VNCPASSWORD inside a container to make the password harder to get.
+	 */
+	hideVncPassword?: boolean;
 }
diff --git a/apps/daemon/src/session/create.ts b/apps/daemon/src/session/create.ts
@@ -42,6 +42,7 @@ export default async function createSession({
 			`STARLIGHT_NOSTR=${nostrUrl}`,
 			`STARLIGHT_ID=${sessionName}`,
 			`VNCPASSWORD=${pass}`,
+			`WIPEVNCENV=${config.session.hideVncPassword ? "true" : "false"}`,
 			...envArray,
 		],
 		NetworkDisabled: offline || false,

diff --git a/workspaces/scripts/start.sh b/workspaces/scripts/start.sh
@@ -1,7 +1,10 @@
 #!/bin/bash
 echo $VNCPASSWORD | vncpasswd -f > /home/stardust/.vnc/passwd
-export VNCPASSWORD=hahayes
-unset VNCPASSWORD
+if [[ $WIPEVNCENV == "true" ]]; then
+    # haha yes -proudparrot2
+    unset VNCPASSWORD
+    unset WIPEVNCENV
+fi
 vncserver -kill :1
 sudo rm -rf /run/dbus
 sudo mkdir -p /run/dbus