MAINT: use random Generator instead of RandomState #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the intent was to switch from use of
RandomState
s toGenerator
s, but the transition is incomplete. I searched for occurences ofrandom.rand
(which also findsrandn
andrandint
) and replaced them.@tupui would you check me here? Some things to look for:
rng
is defined where it's usedrng
is defined only once (i.e. I didn't add it a new one where it was unneeded)random.rand
with separate positional arguments has been replaced withrng.random
with single positional argumentrandom.randn
with a positional arguments has been changed torng.normal
withsize
keyword argument, etc.random.randint
has been replaced withrng.integers
(signatures are compatible, right?)