Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ideal.radical and Ring.nilradical #39549

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add Ideal.radical and Ring.nilradical #39549

wants to merge 3 commits into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Feb 20, 2025 •
edited
Loading

More category-generic methods.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

user202729
user202729 commented Feb 20, 2025
View reviewed changes
src/sage/rings/ideal.py
sage: ZZ.ideal(12).radical()
Principal ideal (6) of Integer Ring
"""
return self.ring().ideal(self.gen().radical())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for context, this is for Ideal_pid.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 626f7c9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For a followup PR, the Zmod should have a defining_ideal() method since they are supposed to be treated as quotient rings...I don't really like the hack in _lift() (but it is was already there before).

@user202729 user202729 mentioned this pull request Feb 21, 2025
Open
5 tasks
@user202729
Copy link
Contributor Author

user202729 commented Feb 21, 2025 •
edited
Loading

Wait a minute, won't return self.zero_ideal() ignore the ideal_class= keyword argument?

Edit: reverted that change (method to be simplified in some future pull request), please review again.

The follow-up pull request is at #39559 (plus some simplification, but might be too short for your preference)

@user202729 user202729 marked this pull request as draft February 21, 2025 09:42
@user202729 user202729 marked this pull request as ready for review February 21, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: algebra s: needs review t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@user202729 @tscrim