Fixed issue causing logarithm of base 0 to not give either of the possible correct answers. #39547
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 5ee0e25; changes) is ready! 🎉 |
|
Looks good, except that there should be a blank line after the line you added with a double-colon at the end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally described as a sub-issue by Dave Morris in #38971. The issue details how taking the logarithm of base 0 of 6 gives neither 0 nor gives an error it gives ln(6). Since these two behaviors are the major behaviors being debated this is definitely wrong. The fix is very easy and is detailed in a comment by Dave Morris.
📝 Checklist
⌛ Dependencies