-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor %%cython to use IPython magic_arguments module #39434
base: develop
Are you sure you want to change the base?
Refactor %%cython to use IPython magic_arguments module #39434
Conversation
Documentation preview for this PR (built with commit 57d1a72; changes) is ready! 🎉 |
The documentation rendering doesn't seem to work too well? Obviously because of the added text in the docstring by the decorators.
Besides, why is the initial line |
Then I see no real benefit of using the IPython helper module for sage users... |
Refactor to use https://ipython.readthedocs.io/en/stable/api/generated/IPython.core.magic_arguments.html
Feature was originally added in #38945 before I realize the IPython helper module exists.
There's slight change in error message for unbalanced quotes, but I think it doesn't matter. (Edit: for simple cases it doesn't matter. See discussion in ipython/ipython#2001 )
📝 Checklist
⌛ Dependencies