Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Consolidate creation of SourceId from manifest path #15172

Merged
merged 2 commits into from
Feb 12, 2025
Merged

refactor: Consolidate creation of SourceId from manifest path #15172

merged 2 commits into from
Feb 12, 2025

Conversation

epage
Copy link
Contributor

@epage epage commented Feb 11, 2025

What does this PR try to resolve?

This preps more features for cargo-script support and makes it clearer where we don't yet support it.

How should we test and review this PR?

Additional information

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2025
weihanglo
weihanglo approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Going to merge it. Just wonder what is the plan.

@weihanglo weihanglo added this pull request to the merge queue Feb 12, 2025
Merged via the queue into rust-lang:master with commit c52d4da Feb 12, 2025
21 checks passed
@epage epage deleted the path branch February 12, 2025 14:38
@epage
Copy link
Contributor Author

epage commented Feb 12, 2025

Just wonder what is the plan.

This was focused on "consolidate logic" / "reduce the chance for mistakes".

I was doing this as I worked towards cargo install --path but I realized that is more like dependencies.*.path and held off for now. When we support that, we'll likely want a similar constructor like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@weihanglo weihanglo

Labels
A-manifest Area: Cargo.toml issues A-workspaces Area: workspaces S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epage @rustbot @weihanglo