Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to .slnx format #98

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Switch to .slnx format #98

merged 1 commit into from
Feb 12, 2025

Conversation

nil4
Copy link
Contributor

@nil4 nil4 commented Feb 12, 2025

With .NET SDK 9.0.200, the legacy GUID goop in solution files is no longer necessary.

Replace it with a concise, human-readable (and editable) XML format.

With .NET SDK 9.0.200, the legacy GUID goop in solution files is no longer necessary.

Replace it with a concise, human-readable (and editable) XML format.
@nil4 nil4 added the enhancement New feature or request label Feb 12, 2025
@nil4 nil4 requested a review from lemonmojo February 12, 2025 08:51
@nil4 nil4 self-assigned this Feb 12, 2025
Copy link
Member

@lemonmojo lemonmojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 LGTM

@lemonmojo
Copy link
Member

@nil4 Now I noticed that there's a mix of slashes and backslashes. Is that intentional?

@nil4
Copy link
Contributor Author

nil4 commented Feb 12, 2025

Not sure if mixing back and forward slashes is expected; this is the result of Rider converting to the new format. (no manual editing)

Perhaps project paths use backslashes, while solution folders and file paths use the other kind. In any case, CI passed both here and elsewhere, so I don't expect any fallout from that.

@lemonmojo
Copy link
Member

@nil4 ok, feel free to merge!

@nil4 nil4 merged commit b783975 into main Feb 12, 2025
3 checks passed
@nil4 nil4 deleted the switch-to-slnx branch February 12, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants