dmactive description should allow system-wide reset
#1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[3.2. Reset Control] allows for a system-wide reset to reset the Debug Module. Link: https://github.com/riscv/riscv-debug-spec/blob/a4678108534bef5b4fbf51e92acacd08b28c17af/debug_module.adoc?plain=1#L100 However, `dmactive` field description used to prohibit **any** other DM reset mechanism. The commit fixes this inconsistency.
|
I don't think this is inconsistent. There should not exist a separate mechanism that resets the DM, but if there is then it must also reset all the harts. It might be worth mentioning that caveat about resetting all the harts in the dmactive description, but we shouldn't change the language away from "this should not exist." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3.2. Reset Control] allows for a system-wide reset to reset the Debug Module.
Link:
riscv-debug-spec/debug_module.adoc
Line 100 in a467810
However,
dmactivefield description used to prohibit any other DM reset mechanism.The commit fixes this inconsistency.