Test Cython code exposed externally #376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 18, 2025
Expose class structure in `libucxx.pxd`. This change is useful so that projects building on top of the Python interface can take `shared_ptr<ucxx::Component>` objects and plug those objects into their C++ backends. Although it's not possible to define private attributes in a `cdef class`, we attempt to mark them private with the leading underscore in their names, such as `UCXContext._context`, and then provide a `UCXContext.get_ucxx_shared_ptr` for those members that are expected to be externally usable. Testing will be handled as part of #376. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for #372 that exposed certain parts of the Cython API for external usage. In this PR, proper tests are added, including the require infrastructure to build the tests and run in CI.