Support CPU execution for make_blobs #6253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
added
feature request
This was referenced Jan 23, 2025
betatim
reviewed
Jan 29, 2025
Comment on lines
172
to
174
| # Set the default output type to "cupy". This will be ignored if the user | ||
| # has set `cuml.global_settings.output_type`. Only necessary for array | ||
| # generation methods that do not take an array as input |
There was a problem hiding this comment.
What does the output type "array" mean? Does it mean "leave it as the type that it is" or will it convert to a cuml array?
betatim
reviewed
Jan 29, 2025
| order=order, | ||
| ) | ||
|
|
||
| assert out.shape == (n_samples, n_features), "out shape mismatch" |
There was a problem hiding this comment.
Should we add an assert to check that out is a cupy/numpy array when the device type is gpu/cpu? At least that would be my expectation on how make_blobs should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
make_blobsrespects globally-set device type.