Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dtype objects are passed within Column.astype #17978

Open
wants to merge 18 commits into
base: branch-25.04
Choose a base branch
from
Open

Ensure dtype objects are passed within Column.astype #17978

wants to merge 18 commits into from

Conversation

mroeschke
Copy link
Contributor

Description

Continuation of #17918

  • Some modified astype calls might be from Series/Index/etc., but IMO it's OK if we are a bit stricter and pass dtype objects when calling those methods too
  • Added some stricter typings to Column.as_*_column since they are called by Column.astype

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 11, 2025
@mroeschke mroeschke self-assigned this Feb 11, 2025
@mroeschke mroeschke requested a review from a team as a code owner February 11, 2025 02:06
@mroeschke mroeschke mentioned this pull request Feb 12, 2025
Open
@mroeschke mroeschke mentioned this pull request Feb 13, 2025
Merged
3 tasks
@mroeschke
Copy link
Contributor Author

I broke off some changes into #18008 as I think there might need to be some bug/feature implementations needed to make dtype objects required here

@mroeschke mroeschke mentioned this pull request Feb 14, 2025
Open
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@mroeschke
Pass dtype objects to Column.astype (#18008)
81bb6f1 
Broken off from #17978

This passes more dtype objects to `Column.astype` but does not _ensure_ that a dtype object is passes unlike in #17978

Also it appears we avoid surfacing from warnings from pandas within our tests.

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #18008
@mroeschke mroeschke mentioned this pull request Feb 19, 2025
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Feb 20, 2025
@mroeschke
Pass more dtype objects to astype calls (#18044)
eb5c309 
Broken off from #17978

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Matthew Murray (https://github.com/Matt711)

URL: #18044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr