Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popper] Add option to disable update position on layout shift #3359

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

martinsvinicius
Copy link

Description

This PR aims to allow setting layoutShift in floating-ui onUpdate params through PopperContentProps by adding an additional prop called updatePositionOnLayoutShift.

I also added a new storybook story to demonstrate its usage.

Closes #2555

Copy link

@carlosbensant carlosbensant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@martinsvinicius
Copy link
Author

@chaance is there any chance this gets merged?

@chaance chaance self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable popover autoUpdate
3 participants